Skip to content

Commit

Permalink
Release v7.2; don't focus editor on auto-parse
Browse files Browse the repository at this point in the history
  • Loading branch information
molsonkiko committed Apr 20, 2024
1 parent 9ceb277 commit 3ecaf28
Show file tree
Hide file tree
Showing 7 changed files with 47 additions and 48 deletions.
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Change Log
All [notable changes](#710---2024-02-28) to this project will be documented in this file.
All [notable changes](#720---2024-04-19) to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).
Expand Down Expand Up @@ -47,10 +47,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- `loop()` function used in `s_sub` callbacks is not thread-safe. *This doesn't matter right now* because RemesPath is single-threaded, but it could matter in the future.
- __GrepperForm loses its JSON permanently when the buffer associated with its treeview is deleted.__
- Since v7.0, holding down `Enter` in a multiline textbox (like the [tree viewer query box](/docs/README.md#remespath)) only adds one newline when the key is lifted.
- Maybe refresh error form automatically when doing the automatic parse (but not schema validation) after editing?
- Maybe use pre-7.1 (dictionary-based rather than indicator-based) [selection remembering](/docs/README.md#working-with-selections) for Notepad++ 8.5.5 and earlier? Indicators are risky with those older NPP's because of the lack of `NPPM_ALLOCATEINDICATOR`.

## [7.2.0] - (UNRELEASED) YYYY-MM-DD
## [7.2.0] - 2024-04-19

### Added

Expand All @@ -61,6 +60,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1. Made it so that reloading the [error form](/docs/README.md#error-form-and-status-bar) by pressing `Enter` would not cause certain message boxes to appear, to eliminate a potential "infinite" loop where the user would hit `Enter` to close the message box, and that moved focus back to the error form, which then repeated the cycle when they lifted the `Enter` key.
2. [Automatic validation](/docs/README.md#automatically-check-for-errors-after-editing) when `auto_validate` is true no longer opens the prompt asking if user wants to open the error form (if [`offer_to_show_lint`](/docs/README.md#parser-settings) is true), because that could cause Notepad++ to crash or hang forever (see [issue 60](https://github.com/molsonkiko/JsonToolsNppPlugin/issues/60#issuecomment-2065419075)).
3. Made it so that automatic JSON schema validation (that is, any validation not manually invoked by the plugin menu command) no longer causes the caret to move to the location of the first schema validation error.
4. Automatic validation (including non-schema validation) now refreshes the error form.

### Fixed

Expand Down
1 change: 0 additions & 1 deletion JsonToolsNppPlugin/Main.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1286,7 +1286,6 @@ private static void RefreshErrorFormInOwnThread(string fname)
if (errorForm.IsDisposed || !TryGetInfoForFile(fname, out JsonFileInfo info) || info.lints == null)
return;
errorForm.Reload(fname, info.lints);
Npp.editor.GrabFocus();
}));
}

Expand Down
4 changes: 2 additions & 2 deletions JsonToolsNppPlugin/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@
// Build Number
// Revision
//
[assembly: AssemblyVersion("7.1.0.4")]
[assembly: AssemblyFileVersion("7.1.0.4")]
[assembly: AssemblyVersion("7.2.0.0")]
[assembly: AssemblyFileVersion("7.2.0.0")]
Binary file modified JsonToolsNppPlugin/Release_x64.zip
Binary file not shown.
Binary file modified JsonToolsNppPlugin/Release_x86.zip
Binary file not shown.
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,7 @@ Thus, `cot` would give the icon sequence `(compress, path to current position, t

## Check JSON syntax now ##

*Added in version [7.2](/CHANGELOG.md#720---unreleased-yyyy-mm-dd).*
*Added in version [7.2](/CHANGELOG.md#720---2024-04-19).*

This command checks JSON syntax and updates the [error form and status bar](/docs/README.md#error-form-and-status-bar). It *will not* validate using JSON schema. If there are any [remembered selections](#working-with-selections), it will only parse those selections.

Expand Down
Loading

0 comments on commit 3ecaf28

Please sign in to comment.