Create EcKey without intermediate Pkey in gen_vapid_key() #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Kaleb-Reid , I had the same problem today and can confirm that thanks to your patch, mollysocket compiles and runs like a charm on OpenBSD 7.6 . |
Kaleb-Reid
changed the title
Kaleb-Reid
changed the title
Kaleb-Reid
changed the title
Kaleb-Reid
force-pushed
the
libressl-fix-vapid
branch
from
1249ff1 to
043bf4b
Compare
Kaleb-Reid
force-pushed
the
libressl-fix-vapid
branch
from
043bf4b to
e61872d
Compare
|
Thanks :) |
|
I had to change the JWT crate because it can generate broken signatures. @Kaleb-Reid Can you test the main branch with LibreSSL ? |
|
Tested on OpenBSD, everything ok here. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes building with LibreSSL as PKey::ec_gen() is not supported by it, whereas EcKey::generate() is.
Fixes #58.