Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete folder from project #139

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Conversation

marikaris
Copy link
Contributor

@marikaris marikaris commented Oct 1, 2024

Test by logging in and then deleting a folder from armadillo:

armadillo.login("http://localhost:8080")
armadillo.delete_project_folder("project", "folder") # replace with a project and folder name in your armadillo

Verify the folder is gone, but the other folders in the project remain.

@marikaris marikaris changed the title feat: Delete project folder feat: delete folder from project Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.9%. Comparing base (71f33ce) to head (c0ba7ac).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
R/names.R 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #139     +/-   ##
========================================
+ Coverage    85.3%   85.9%   +0.6%     
========================================
  Files           9       9             
  Lines         526     549     +23     
========================================
+ Hits          449     472     +23     
  Misses         77      77             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marikaris marikaris requested a review from timcadman October 4, 2024 07:31
@@ -5,7 +5,7 @@
#'
#' @noRd
.to_readable_name <- function(bucket_name) {
name_parts <- unlist(strsplit(bucket_name, "-"))
name_parts <- .split_and_unlist(bucket_name, "-")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov would like a test for .split_and_unlist

@marikaris marikaris merged commit bc8551a into master Oct 7, 2024
4 checks passed
@marikaris marikaris deleted the feat/delete-project-folder branch October 7, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As Armadillo datamanager I want to be able to delete a folder from my project
2 participants