-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete folder from project #139
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #139 +/- ##
========================================
+ Coverage 85.3% 85.9% +0.6%
========================================
Files 9 9
Lines 526 549 +23
========================================
+ Hits 449 472 +23
Misses 77 77 ☔ View full report in Codecov by Sentry. |
@@ -5,7 +5,7 @@ | |||
#' | |||
#' @noRd | |||
.to_readable_name <- function(bucket_name) { | |||
name_parts <- unlist(strsplit(bucket_name, "-")) | |||
name_parts <- .split_and_unlist(bucket_name, "-") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov would like a test for .split_and_unlist
Test by logging in and then deleting a folder from armadillo:
Verify the folder is gone, but the other folders in the project remain.