Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subset #133

Merged
merged 4 commits into from
Jun 27, 2024
Merged

fix: subset #133

merged 4 commits into from
Jun 27, 2024

Conversation

timcadman
Copy link
Contributor

To test

  • Checkout branch
  • run devtools::load_all()
  • run devtools::check()
  • Code review
  • run this code, logging in using urls with and without the slash:
url <- "https://armadillo-demo.molgenis.net"
armadillo.login(url)
vars_to_subset <- c("child_id", "recruit_age", "coh_country", "mother_id", "preg_no", "child_no", 
                    "cob_m", "ethn1_m", "ethn2_m", "ethn3_m")

armadillo.subset(
  input_source = "arguments",
  source_project = "lifecycle",
  source_folder = "core", 
  source_table = "nonrep",
  target_project = "fix-subset", 
  target_folder = "core", 
  target_table = "testtable", 
  target_vars = vars_to_subset)

armadillo.delete_project("fix-subset")

url <- "https://armadillo-demo.molgenis.net/"
armadillo.login(url)

armadillo.subset(
  input_source = "arguments",
  source_project = "lifecycle",
  source_folder = "core", 
  source_table = "nonrep",
  target_project = "fix-subset", 
  target_folder = "core", 
  target_table = "testtable", 
  target_vars = vars_to_subset)

The view should work correctly in both cases.

@timcadman timcadman requested a review from marikaris June 27, 2024 10:37
@timcadman timcadman linked an issue Jun 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.3%. Comparing base (579faa0) to head (1880b38).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #133     +/-   ##
========================================
+ Coverage    85.2%   85.3%   +0.1%     
========================================
  Files           9       9             
  Lines         522     526      +4     
========================================
+ Hits          445     449      +4     
  Misses         77      77             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timcadman timcadman merged commit 9d17d72 into master Jun 27, 2024
4 checks passed
@timcadman timcadman deleted the fix/subset branch June 27, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using armadillo.subset
2 participants