Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalogue): add attributes for valid dcat #4692

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BrendaHijmans
Copy link
Contributor

@BrendaHijmans BrendaHijmans commented Feb 7, 2025

Keep in branch for testing, not ready for merge

What are the main changes you did

  • add attributes for valid dcat output

see https://github.com/molgenis/GCC/issues/1029

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • check Version number and bump
  • dcat:theme = Health (Health / http://publications.europa.eu/resource/authority/data-theme/HEAL) > add in 'header rdf' > add in catalogue-reformat of model or rdf
  • dcat:license in header rdf as placeholder
  • would be nice to have some kind of conversion that takes all Resources that have an 'inSeries' pointing to them from CollectionEvents as DatasetSeries and all other as just Dataset.

@BrendaHijmans BrendaHijmans changed the title feat(catalogue): add attributes for valid dcat feat(catalogue): add attributes for valid dcat, closes #1029 Feb 10, 2025
@BrendaHijmans BrendaHijmans requested review from mswertz and YpeZ and removed request for mswertz February 10, 2025 13:36
@BrendaHijmans BrendaHijmans changed the title feat(catalogue): add attributes for valid dcat, closes #1029 feat(catalogue): add attributes for valid dcat Feb 10, 2025
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is nice to make our data model closer to DCAT in areas where that makes sense such as these ones.

@YpeZ
Copy link
Contributor

YpeZ commented Feb 12, 2025

I have my doubts about the validity of creator being a ref_array in these tables. In Dublin Core this attribute is described as

An entity responsible for making the [resource].

They seem to be pretty strict about it, but having multiple creators is reasonable for larger resources such as Resources and Collection Events

@BrendaHijmans
Copy link
Contributor Author

BrendaHijmans commented Feb 12, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants