Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use footer from settings #4689

Merged
merged 15 commits into from
Feb 12, 2025
Merged

Conversation

chinook25
Copy link
Contributor

@chinook25 chinook25 commented Feb 7, 2025

What are the main changes you did

  • Changed the directory footer so that it is loaded from the directory settings.
  • Closes https://github.com/molgenis/GCC/issues/548
  • Settings are now only loaded once (they where retrieved at least 3 times).
  • No longer need to refresh after saving settings.

How to test

  • Go to the directory.
  • Note the lack of specific footer
  • Login
  • Go to the settings of the app
  • in the JSON editor edit the footerfield, or if not present, add it.
  • save
  • See that your edit now appears at the near bottom of the page.

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@@ -39,13 +36,26 @@ export const useSettingsStore = defineStore("settingsStore", () => {
landingpage: initialLandingpage,
pageSize: 12,
i18n,
banner: undefined, //"<div style='background-color: #72f6b2; padding: 10px; text-align: center;'>I am in a banner</div>"
banner: ``,
footer: ``,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose a good default would help?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked Dieuwke what would be prefered here.

@chinook25 chinook25 marked this pull request as ready for review February 11, 2025 10:35
Copy link
Contributor

@dtroelofsprins dtroelofsprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to include the current footer, but gave up after some attempts. Then used just some plain text and styling html code and that indeed works fine. Footer is nicely placed, under the cards and above the general MOLGENIS EMX2 footer, just as it is now.

@chinook25 chinook25 merged commit 32c4315 into master Feb 12, 2025
1 of 4 checks passed
@chinook25 chinook25 deleted the feat/directory-settings-footer branch February 12, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants