-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use footer from settings #4689
Conversation
@@ -39,13 +36,26 @@ export const useSettingsStore = defineStore("settingsStore", () => { | |||
landingpage: initialLandingpage, | |||
pageSize: 12, | |||
i18n, | |||
banner: undefined, //"<div style='background-color: #72f6b2; padding: 10px; text-align: center;'>I am in a banner</div>" | |||
banner: ``, | |||
footer: ``, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose a good default would help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked Dieuwke what would be prefered here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to include the current footer, but gave up after some attempts. Then used just some plain text and styling html code and that indeed works fine. Footer is nicely placed, under the cards and above the general MOLGENIS EMX2 footer, just as it is now.
What are the main changes you did
How to test
Checklist