Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rdf): non-required refLink caused RDF API to fail #4688

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix(rdf): non-required refLink caused RDF API to fail #4688

wants to merge 3 commits into from

Conversation

svandenhoek
Copy link
Contributor

What are the main changes you did

  • Fixed non-required refLinks to not brake RDF API.
    • empty check now validates all fields of composite key instead of single one (assumption "composite key has all fields filled" was incorrect for refLink as this would cause REFs to a composite key that use refLink to already have part of the composite key known while the other is null in getReferences())
  • Column.setRefLink() new returns itself.

How to test

  • Test should work

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@svandenhoek svandenhoek marked this pull request as draft February 6, 2025 15:03
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@svandenhoek