Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove flaky test #4686

Merged
merged 2 commits into from
Feb 10, 2025
Merged

chore: remove flaky test #4686

merged 2 commits into from
Feb 10, 2025

Conversation

connoratrug
Copy link
Contributor

What are the main changes you did

This test modifies the status in the test database, which can lead to flaky behavior if the test fails or is aborted, potentially affecting other tests.

Temporarily removing this test until we can discuss a more reliable approach for testing stateful pages.

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

This test changes the status in the test database, if the test fails or is aborted this may effect other test , causing flacky behavour.
Remove this test untill we have discussed a better way of testing statefull pages
@connoratrug connoratrug added the chore A task that improves the code but doesn't add new functionality label Feb 6, 2025
@connoratrug connoratrug self-assigned this Feb 6, 2025
Copy link

sonarqubecloud bot commented Feb 7, 2025

@connoratrug connoratrug merged commit 6f1226c into master Feb 10, 2025
7 checks passed
@connoratrug connoratrug deleted the chore/remove-flacky-test branch February 10, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that improves the code but doesn't add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants