Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalogue): extend Resources table to accomodate description of samples collected next to the data #4681

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hslh
Copy link
Contributor

@hslh hslh commented Feb 5, 2025

What are the main changes you did

  • see issue

@mswertz mswertz changed the title feat(catalogue): extend Resources table feat(catalogue): extend Resources table to accomodate description of samples collected next to the data Feb 5, 2025
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paar kleine vraagjes, maar ik denk dat ik antwoord al weet: dit is voor mogelijk maken de directory data op te nemen. Op basis daarvan de titel aangepast, klopt dat?

Wbt de samples en imaging heb ik dan niet snel zorgen, wel als het gaat om de data dat we er snel tegenaan lopen meerdere data beschrijvingen te hebben. Daar zou ik dan nog even kritisch naar willen kijken, of dingen niet gemapped/gemerged kunnen worden naar bestaande coderingen.

data/_models/shared/Resources.csv Show resolved Hide resolved
data/_models/shared/Resources.csv Show resolved Hide resolved
data/_models/shared/Resources.csv Show resolved Hide resolved
hslh added a commit that referenced this pull request Feb 6, 2025
@hslh
Copy link
Contributor Author

hslh commented Feb 6, 2025

paar kleine vraagjes, maar ik denk dat ik antwoord al weet: dit is voor mogelijk maken de directory data op te nemen. Op basis daarvan de titel aangepast, klopt dat?

Wbt de samples en imaging heb ik dan niet snel zorgen, wel als het gaat om de data dat we er snel tegenaan lopen meerdere data beschrijvingen te hebben. Daar zou ik dan nog even kritisch naar willen kijken, of dingen niet gemapped/gemerged kunnen worden naar bestaande coderingen.

Ja, in de titel van het issue had ik het wel duidelijk staan.

Mijn idee is om dit als een soort demo (met data) te hebben en dat we het dan in de groep kunnen bespreken om te zien wat voor bezwaren er zijn.

Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

op kleine comments na ziet dit er goed uit. Denk ik wel goed deze kennis keer te delen op data model meet want in RD3 deel data model zit er ook veel sample info en ik denk mooi die met dezelfde coderingen te voorzien.

@@ -0,0 +1,8 @@
tableName,tableExtends,tableType,columnName,columnType,key,required,refSchema,refTable,refLink,refBack,refLabel,defaultValue,validation,visible,computed,semantics,profiles,label,description
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

data/_models/shared/Resources.csv Show resolved Hide resolved
data/_models/shared/Resources.csv Show resolved Hide resolved
@@ -67,6 +69,9 @@ Resources,,people involved,refback,,,,Contacts,,resource,,http://www.w3.org/ns/d
Resources,,organisations involved,refback,,,,Organisations,,resource,,"http://purl.org/dc/terms/publisher,http://purl.org/dc/terms/creator",Organisations involved and their role(s),"DataCatalogueFlat,EMA,CohortsStaging,RWEStaging,UMCGCohortsStaging,NetworksStaging,UMCUCohorts,INTEGRATE"
Resources,,networks involved,refback,,,,Resources,,resources,,,The consortia or networks that this resource is part of,"DataCatalogueFlat,EMA"
Resources,,networks other,text,,,,,,,,,List the names of any other networks that are not listed and this resource is involved in,EMA
Resources,,"available data, imaging and samples,heading",,,,,,,,,,Data model and contents,"DataCatalogueFlat,EMA,RWEStaging,CohortsStaging,UMCGCohortsStaging"
Resources,,data categories,ontology_array,,,CatalogueOntologies,Data categories,,,,http://www.w3.org/ns/dcat#theme,Types of data collected in this resource,"DataCatalogueFlat,CohortsStaging"
Resources,,number of samples,int,,,,,,,,,Total number of samples included in this resource,"DataCatalogueFlat,CohortsStaging"
Resources,,available data and samples,heading,,,,,,,,,Data model and contents,"DataCatalogueFlat,EMA,RWEStaging,CohortsStaging"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zit deze heading er nu 2x in? Is dat handig? op regel 72 en 75 is nu min of meer hetzelfde. Voorstel samenvoegen en hernoemen? Of zie je dat anders?

@@ -86,6 +91,11 @@ Resources,,diagnosis medical event vocabulary other,text,,,,,,,,,"If 'other', wh
Resources,,data dictionary available,bool,,,,,,,,,Are a data dictionary and a data model available?,"DataCatalogueFlat,RWEStaging"
Resources,,disease details,ontology_array,,,CatalogueOntologies,MedDRA,,,,,"If data on a specific disease is collected, which diseases does the data source collect information on","DataCatalogueFlat,EMA,RWEStaging"
Resources,,disease details other,text,,,,,,,,,Specify disease details if not present in MedDRA,EMA
Resources,,biospecimen types,ontology_array,,,CatalogueOntologies,BiospecimenType,,,,,"If the data bank contains biospecimens, what types of specimen","DataCatalogueFlat,CohortsStaging"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is biospecimen types niet hetzelfde als material types? Of hebben we die alleen op collection event? In any case graag gelijk houden.

@@ -0,0 +1,119 @@
order,name,label,parent,codesystem,code,ontologyTermURI,definition
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, dat is ook heel fijn. David en Willemijn hadden het hier ook al over want op individuele samples nivo ook nodig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants