Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename nuxt3-ssr to catalogue #4672

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented Feb 3, 2025

What are the main changes you did

rename app 'nuxt3-ssr' to 'catalogue'
rename app-route 'ssr-catalogue' to 'catalogue'

now the app name matches the route name ( similar to the order apps )

On release would need to update proxy for users to still use the old path

How to test

-check that that catalogue still works and the url bar show 'catalogue' instead of 'ssr-catalogue'

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@connoratrug connoratrug marked this pull request as ready for review February 5, 2025 14:04
@connoratrug connoratrug added the chore A task that improves the code but doesn't add new functionality label Feb 6, 2025
@connoratrug connoratrug self-assigned this Feb 7, 2025
Copy link

sonarqubecloud bot commented Feb 7, 2025

@connoratrug
Copy link
Contributor Author

suggest to wait with merge until we check with ops on updating the nginx proxy config ( we can update the config before the deploy )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that improves the code but doesn't add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants