feat(RDF): semantic ontologies #4623
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocking on #4566 (might cause merge conflicts) |
Conflicts: backend/molgenis-emx2-rdf/src/main/java/org/molgenis/emx2/rdf/ColumnTypeRdfMapper.java backend/molgenis-emx2-rdf/src/test/java/org/molgenis/emx2/rdf/ColumnTypeRdfMapperTest.java
|
mswertz
reviewed
Feb 10, 2025
| .getRefTable() | ||
| .getTable() | ||
| .query() | ||
| .select(s("name"), s("ontologyTermURI")) |
There was a problem hiding this comment.
oei, dat is erg duur om dat per stuk te doen. Komt dit vaak voor? Want dan zou je liever de originele query expanden?
There was a problem hiding this comment.
Wisselt, maar denk dat als het duur is dat het wel "te vaak" zal zijn.
Zal idd wel even kijken of ik ofwel de query kan uitbreiden met een subquery of ee andere oplossing kan vinden dan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did
ontologyTermURIinstead #4222ontologyTermURIis found, semantics predicate will use local server-specific IRI instead (similar to old behaviour)How to test
Checklist