Skip to content

Commit

Permalink
Lock sqlite3 to v1
Browse files Browse the repository at this point in the history
ActiveRecord specifies a gem version when the adapter is loaded and the
most recent versions of Rails lock to ~> 1.4, which won't work with the
most recent sqlite3 version, which is now 2.x.

This is just for tests, so it'll be up to each app to make sure they're
using the correct sqlite version for their Rails version (as it always
has been).
  • Loading branch information
molawson committed May 17, 2024
1 parent 59296f6 commit afdad29
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ gem "mysql2"
gem "pg"
gem "rake", ">= 12.3.3"
gem "rspec", "~> 3.0"
gem "sqlite3"
gem "sqlite3", "~> 1.0"
gem "standard", "~> 1.0"
gem "timecop"

Expand Down
8 changes: 6 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.3)
sqlite3 (1.4.2)
sqlite3 (1.7.3-arm64-darwin)
sqlite3 (1.7.3-x86_64-darwin)
sqlite3 (1.7.3-x86_64-linux)
standard (1.7.0)
rubocop (= 1.25.0)
rubocop-performance (= 1.13.2)
Expand All @@ -83,6 +85,8 @@ GEM

PLATFORMS
arm64-darwin-21
arm64-darwin-22
arm64-darwin-23
x86_64-darwin-19
x86_64-linux

Expand All @@ -94,7 +98,7 @@ DEPENDENCIES
rake (>= 12.3.3)
rspec (~> 3.0)
simplecov
sqlite3
sqlite3 (~> 1.0)
standard (~> 1.0)
timecop

Expand Down
2 changes: 1 addition & 1 deletion gemfiles/activerecord_5_2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "mysql2"
gem "pg"
gem "rake", ">= 12.3.3"
gem "rspec", "~> 3.0"
gem "sqlite3"
gem "sqlite3", "~> 1.0"
gem "standard", "~> 1.0"
gem "timecop"
gem "activerecord", "~> 5.2.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/activerecord_6_0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "mysql2"
gem "pg"
gem "rake", ">= 12.3.3"
gem "rspec", "~> 3.0"
gem "sqlite3"
gem "sqlite3", "~> 1.0"
gem "standard", "~> 1.0"
gem "timecop"
gem "activerecord", "~> 6.0.3"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/activerecord_6_1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "mysql2"
gem "pg"
gem "rake", ">= 12.3.3"
gem "rspec", "~> 3.0"
gem "sqlite3"
gem "sqlite3", "~> 1.0"
gem "standard", "~> 1.0"
gem "timecop"
gem "activerecord", "~> 6.1.2"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/activerecord_7_0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "mysql2"
gem "pg"
gem "rake", ">= 12.3.3"
gem "rspec", "~> 3.0"
gem "sqlite3"
gem "sqlite3", "~> 1.0"
gem "standard", "~> 1.0"
gem "timecop"
gem "activerecord", "~> 7.0.1"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/activerecord_7_1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "mysql2"
gem "pg"
gem "rake", ">= 12.3.3"
gem "rspec", "~> 3.0"
gem "sqlite3"
gem "sqlite3", "~> 1.0"
gem "standard", "~> 1.0"
gem "timecop"
gem "activerecord", "~> 7.1.0"
Expand Down

0 comments on commit afdad29

Please sign in to comment.