Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phoenix_html to v4 #450

Closed
wants to merge 1 commit into from
Closed

Update phoenix_html to v4 #450

wants to merge 1 commit into from

Conversation

adamu
Copy link
Contributor

@adamu adamu commented Apr 3, 2024

@adamu adamu force-pushed the phoenix_html_v4 branch from 3db8ef7 to 067f8b1 Compare April 3, 2024 06:58
@cpjolicoeur
Copy link
Member

@adamu Thanks for this PR. I'll take a look at the failing test cases and hope to get this merged in this week.

@cpjolicoeur cpjolicoeur mentioned this pull request Apr 12, 2024
Merged
@cpjolicoeur
Copy link
Member

@adamu we pulled your commit into PR #452 and merged. Will try to cut a new release of Torch with these changes soon.

Thanks again for the contribution.

@cpjolicoeur
Copy link
Member

Torch v5.2.0 released with Phoenix.HTML 4 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update phoenix_html to 4.0.0
2 participants
@adamu @cpjolicoeur