Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used .blocking_rule_sql property match_weights_interactive_history_chart() #2446

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

browo097302
Copy link
Contributor

Type of PR

  • [X ] BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Issue #1387

Give a brief description for the solution you have provided

Added the .blocking_rule_sql property on _blocking_rule_for_training so a readable string is returned instead of an object id code in the chart subtitle. Tested locally and had no errors from this change.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • [X ] Run the linter
  • Run the spellchecker (if appropriate)

@RobinL
Copy link
Member

RobinL commented Oct 4, 2024

Thank you!

@RobinL
Copy link
Member

RobinL commented Oct 4, 2024

Closes #1387

@RobinL RobinL merged commit d991777 into moj-analytical-services:master Oct 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants