Skip to content

Commit

Permalink
Merge pull request #132 from moj-analytical-services/add-additional-r…
Browse files Browse the repository at this point in the history
…ole-regex

Added additional regex role rule
  • Loading branch information
gwionap authored Jul 18, 2024
2 parents cd82af2 + b0fdc90 commit 58e68fa
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v5.5.19 - 2024-07-18

- Added aws role rule

## v5.5.18 - 2024-05-13

- Made s3_output explicit in _create_temp_database
Expand Down
2 changes: 1 addition & 1 deletion pydbtools/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@
)
from .utils import s3_path_join # noqa: F401

__version__ = "5.5.18"
__version__ = "5.5.19"
4 changes: 4 additions & 0 deletions pydbtools/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@
r"^[a-z0-9]{7,8}-airflow_", # airflow
r"[a-z0-9]{7,8}-",
),
(
r"airflow_", # airflow
None,
),
(
r"^[0-9]+$", # numeric
None,
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[tool]
[tool.poetry]
name = "pydbtools"
version = "5.5.18"
version = "5.5.19"
description = "A python package to query data via amazon athena and bring it into a pandas df using aws-wrangler."
license = "MIT"
authors = ["Karik Isichei <[email protected]>"]
Expand Down
1 change: 1 addition & 0 deletions tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def test_pyproject_toml_matches_version():
("abcde:[email protected]", "my_name"),
("3f7f9e93-airflow_prod_role_name", "airflow_prod_role_name"),
("3f7f9e9-airflow_prod_role_name", "airflow_prod_role_name"),
("abcde:airflow_prod_role_name", "airflow_prod_role_name"),
],
)
def test_clean_user_id(test_input, expected):
Expand Down

0 comments on commit 58e68fa

Please sign in to comment.