Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v0.13.2 #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 5, 2025

🤖 New release

  • tinytime: 0.13.2
Changelog

0.13.2 - 2025-02-05

Other


This PR was generated with release-plz.

Copy link
Contributor

@fabian-braun fabian-braun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether the replacement of thiserror implies a different formatting of the error we return / a different error message. In that case we should make this a minor release instead of a path

@rinde
Copy link
Collaborator

rinde commented Feb 7, 2025

@fabian-braun I'm not sure if thiserror treats the string differently, but even if it does, I wonder if it warrants a minor release considering that the error type remains the same. I would say that the error string is only there for printing purposes and should never be matched on, that is what the TimeWindowError::StartAfterEnd is for IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants