chore: update package.json exports for newer nodejs resolution #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
exportsfield inpackage.jsonwhich is required in recent nodejs version to resolve the correct variation of the build result.In this PR I don't want to make a huge breaking change so I specify the
typetocommonjs. But a general approach to support hybrid (i.e. ESM + CJS + others) package is to settypeasmoduleand name the cjs output a.cjsextension.By the way, it looks like the pnpm lockfile was created long long ago, in my local, pnpm was trying to re-generate the whole file, so I didn't upload the lock file onto this PR. If it is required, you might need to update it on your side before this PR.