Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: ignore loader for file update if not applicable #951

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/routes/v3/version_file.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use super::ApiError;
use crate::auth::checks::{filter_visible_versions, is_visible_version};
use crate::auth::{filter_visible_projects, get_user_from_headers};
use crate::database::models::loader_fields::Loader;
use crate::database::redis::RedisPool;
use crate::models::ids::VersionId;
use crate::models::pats::Scopes;
Expand Down Expand Up @@ -149,6 +150,8 @@ pub async fn get_update_from_hash(
if let Some(project) =
database::models::Project::get_id(file.project_id, &**pool, &redis).await?
{
let all_loaders_data: Vec<Loader> = Loader::list(&**pool, &redis).await?;

let versions = database::models::Version::get_many(&project.versions, &**pool, &redis)
.await?
.into_iter()
Expand All @@ -160,7 +163,22 @@ pub async fn get_update_from_hash(
.any(|y| y.as_str() == x.inner.version_type);
}
if let Some(loaders) = &update_data.loaders {
bool &= x.loaders.iter().any(|y| loaders.contains(y));
let loaders = loaders
.iter()
.filter(|loader| {
let loader_data = all_loaders_data
.iter()
.find(|game_loader| game_loader.loader == **loader)
.unwrap();

loader_data
.supported_project_types
.iter()
.any(|project_type| x.project_types.contains(project_type))
})
.collect_vec();

bool &= x.loaders.iter().any(|y| loaders.contains(&y));
}
if let Some(loader_fields) = &update_data.loader_fields {
for (key, values) in loader_fields {
Expand Down