Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6637: Fix skiprows parameter usage for read_excel #6638

Merged
merged 1 commit into from
Oct 9, 2023
Merged

FIX-#6637: Fix skiprows parameter usage for read_excel #6638

merged 1 commit into from
Oct 9, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Oct 8, 2023 •
edited
Loading

What do these changes do?

Since skiprows is not supported, we need to default to pandas if this option is used.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Length Mismatch when using pd.read_excel() #6637
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev marked this pull request as ready for review October 8, 2023 19:52
@anmyachev anmyachev requested a review from a team as a code owner October 8, 2023 19:52
@dchigarev dchigarev merged commit a01ce30 into modin-project:master Oct 9, 2023
37 checks passed
@anmyachev anmyachev deleted the issue6637 branch October 9, 2023 15:24
anmyachev added a commit to anmyachev/modin that referenced this pull request Oct 30, 2023
@anmyachev
FIX-modin-project#6637: Fix 'skiprows' parameter usage for 'read_exce…
1a50916 
…l' (modin-project#6638)

Signed-off-by: Anatoly Myachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Length Mismatch when using pd.read_excel()
2 participants
@anmyachev @dchigarev