-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#4605: Implementation of Small Query Compiler to support small and empty DataFrames #5113
Open
billiam-wang
wants to merge
28
commits into
modin-project:master
Choose a base branch
from
billiam-wang:bill-sqc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
5e552ff
Partial implementation of small query compiler
billiam-wang 1c87589
Working binary, datetime, and string functions for small query compiler
billiam-wang 05a0ee1
Added resample and rolling implementations
billiam-wang 5722d82
Added a few new functions
billiam-wang 9c107aa
Added most mapped functions
billiam-wang a5b951c
Passing most tests in test_general.py
billiam-wang 016de6c
Added changes to fix bugs, still failing tests
billiam-wang 8781a54
Passing additional tests for series and groupby
billiam-wang b6ea7ee
Passing most groupby tests
billiam-wang 170f919
Passing almost all tests except in join sort and groupby
billiam-wang 3b2a02c
Passing all groupby tests except test_dict_agg_rename_mi_columns
billiam-wang d162386
Passed all except 1 tests
billiam-wang ec02113
Passing all tests and added config environment variable for SmallQuer…
billiam-wang 85491ea
Added environment variable to control SmallQueryCompiler
billiam-wang 075a93e
Removed print statements and cleaned up
billiam-wang f018818
More code cleanup
billiam-wang 2f3cf0e
Reset default InitializeWithSmallQueryCompilers envvar to False
billiam-wang bc122f6
Resolved flake and black failures
billiam-wang 46e517f
Removed print statements and fixed import statements
billiam-wang a080898
Fixed more import statements
billiam-wang 8e5f80a
Cleaned up helper functions and fixed test_binary issues
billiam-wang 1be9793
Fixed flake8 and black again
billiam-wang a2c5a6f
Added docstrings for SmallQueryCompiler
billiam-wang 135148d
Made flake8 and black changes
billiam-wang c0df87a
Passing all lint checks
billiam-wang dccf80c
Added documentation for try_cast_to_pandas
billiam-wang 40446d3
Added SmallQueryCompiler CI tests and fixed remaining bugs
billiam-wang 43ff32b
Changed CI test version to 3.9
billiam-wang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks clever, but I think it feels temporary to me - query compilers both use stuff from lower level and are used by higher level, so this integration should eventually be tested upon change in any of the things used throughout the pipeline... this should probably stay for now, but be removed towards the shiny future where the "auto-switch" would happen