MODELIX-971 allProperties missing in ModelQl on INode #895
Conversation
Test Results155 files 155 suites 11m 18s ⏱️ Results for commit 9728470. |
JVM coverage report
|
| } | ||
|
|
||
| override fun getOutputSerializer(serializationContext: SerializationContext): KSerializer<out IStepOutput<Pair<IProperty, String?>>> { | ||
| return serializationContext.serializer<Pair<IProperty, String?>>().stepOutputSerializer(this) |
There was a problem hiding this comment.
This only works, because the test case uses a CLTree with named based roles. Not all implementations of IProperty are serializable. I think we need https://issues.modelix.org/issue/MODELIX-976/Cleanup-relation-between-model-and-meta-model first and then return an IPropertyReference (or IPropertyId, not sure yet) instead, that can be resolved on the client side to an IPropertyDefinition if needed.
There was a problem hiding this comment.
I tested it with a CLTree that uses useRoleIds = true and it works for that case as well.
But your proposed solution would definitely be cleaner.
There was a problem hiding this comment.
Because the role is always wrapped by a PropertyFromName, even if it is an ID. This really needs to be cleaned up.
|
This proposed fix is outdated with the modelql rewrite in core 10.0.0 |
To be verified by reviewers