Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODELIX-969 conceptAlias does not seem to work #878

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

mhuster23
Copy link
Contributor

@mhuster23 mhuster23 commented Jul 8, 2024

Generated concepts did not implement getConceptProperty(name: String).

The generated code now roughly looks like this:

public object _C_UntypedImpl_MyConcept {
    override fun getConceptProperty(name: String): String? = when (name) {
        "alias" -> C_MyConcept.alias
        else -> null
    }
}

public interface C_MyConcept {
    companion object : C_MyConcept {
        override val alias: String = "my concept alias"
    }
}

To be verified by reviewers

  • Relevant public API members have been documented
  • Documentation related to this PR is complete
    • Boundary conditions are documented
    • Exceptions are documented
    • Nullability is documented if used
  • Touched existing code has been extended with documentation if missing
  • Code is readable
  • New features and fixed bugs are covered by tests

… for generated concepts

Generated concepts did not implement getConceptProperty(name: String).
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Test Results

154 files  ±0  154 suites  ±0   10m 58s ⏱️ -14s
897 tests ±0  888 ✅ ±0  9 💤 ±0  0 ❌ ±0 
907 runs  ±0  898 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit b3f1c86. ± Comparison against base commit c477a32.

♻️ This comment has been updated with latest results.

In CI we sometimes hit this timeout leading to failed builds.
Copy link
Contributor

github-actions bot commented Jul 8, 2024

JVM coverage report

Overall Project 53.03% -0.02%
Files changed 84.93% 🍏

File Coverage
ConceptWrapperInterfaceGenerator.kt 80.59% -3.85%
ConceptObjectGenerator.kt 79.19% -0.1% 🍏

@mhuster23 mhuster23 marked this pull request as ready for review July 8, 2024 11:50
@mhuster23 mhuster23 requested a review from slisson as a code owner July 8, 2024 11:50
@mhuster23 mhuster23 merged commit f9d9306 into main Jul 9, 2024
19 checks passed
@mhuster23 mhuster23 deleted the fix/concept-alias-on-generated-concept branch July 9, 2024 07:08
@slisson
Copy link
Member

slisson commented Jul 10, 2024

🎉 This PR is included in version 8.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants