Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bulk-model-sync): add a configuration option to load plugins #831

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

odzhychko
Copy link
Contributor

In simple cases, MPSBulkSynchronizer does not rely on concepts (and in turn of languages and plugins) of the synced nodes to be loaded.
Plugins might become necessary when they provide custom persistence and in other, yet unknown cases.

Depends on modelix/modelix.mps-build-tools#52.
After it is merged and published libs.versions.toml needs to be updated. But the API in bulk-sync-plugin can be reviewed anyway.

I did not add tests.
The test would be complicated, long-running (starts MPS) and only test rather simple logic.
When someone deems test necessary I would add tests, that run one of the sync tasks and assert through the logs, that the specified plugins are loaded.
If someone has a better idea/different opinion on the tests here, please let me know.

To be verified by reviewers

  • Relevant public API members have been documented
  • Documentation related to this PR is complete
    • Boundary conditions are documented
    • Exceptions are documented
    • Nullability is documented if used
  • Touched existing code has been extended with documentation if missing
  • Code is readable
  • New features and fixed bugs are covered by tests

@odzhychko
Copy link
Contributor Author

This PR ist still a draft, because I want to talk about in our refinment.
See https://issues.modelix.org/issue/MODELIX-813/Avoid-changing-resolveInfo-tags-for-unrelated-children#focus=Comments-4-3611.0-0

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Test Results

160 files  160 suites   10m 51s ⏱️
909 tests 900 ✅ 9 💤 0 ❌
919 runs  910 ✅ 9 💤 0 ❌

Results for commit b7528ca.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 19, 2024

JVM coverage report

Overall Project 53.04% -0.08%
Files changed 0%

File Coverage
ModelSyncGradleSettings.kt 0% -9.69%
ModelSyncGradlePlugin.kt 0% -3.8%

In simple cases, `MPSBulkSynchronizer` does not rely on concepts (and in turn of languages and plugins) of the synced nodes to be loaded.
Plugins might become necessary when they provide custom persistence
and in other, yet unknown cases.
@odzhychko odzhychko force-pushed the MODELIX-813-add-option-to-load-plugins branch from 0c3c0e5 to b7528ca Compare July 19, 2024 11:23
@odzhychko odzhychko marked this pull request as ready for review July 19, 2024 11:25
@odzhychko odzhychko requested review from mhuster23 and a team as code owners July 19, 2024 11:25
@odzhychko odzhychko merged commit b739b95 into main Jul 29, 2024
20 checks passed
@odzhychko odzhychko deleted the MODELIX-813-add-option-to-load-plugins branch July 29, 2024 10:15
@slisson
Copy link
Member

slisson commented Jul 30, 2024

🎉 This PR is included in version 8.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants