feat(bulk-model-sync): add a configuration option to load plugins #831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In simple cases,
MPSBulkSynchronizer
does not rely on concepts (and in turn of languages and plugins) of the synced nodes to be loaded.Plugins might become necessary when they provide custom persistence and in other, yet unknown cases.
Depends on modelix/modelix.mps-build-tools#52.
After it is merged and published
libs.versions.toml
needs to be updated. But the API in bulk-sync-plugin can be reviewed anyway.I did not add tests.
The test would be complicated, long-running (starts MPS) and only test rather simple logic.
When someone deems test necessary I would add tests, that run one of the sync tasks and assert through the logs, that the specified plugins are loaded.
If someone has a better idea/different opinion on the tests here, please let me know.
To be verified by reviewers