feat(bulk-model-sync): workaround removed and outdated resolveInfo after import into MPS #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JVM coverage report
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| val modulesToImport = getModulesToImport() | ||
| ModelImporter(rootOfImport, continueOnError).importIntoNodes(modulesToImport) | ||
| println("Import finished.") | ||
| } catch (ex: Exception) { |
Check warning
Code scanning / detekt
The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled. Warning
|
This PR ist still a draft, because I want to talk about in our refinment. |
languitar
reviewed
Jun 19, 2024
...c-lib/mps-test/src/test/kotlin/org/modelix/model/sync/bulk/lib/test/ResolveInfoUpdateTest.kt
Outdated
Show resolved
Hide resolved
...c-lib/mps-test/src/test/kotlin/org/modelix/model/sync/bulk/lib/test/ResolveInfoUpdateTest.kt
Outdated
Show resolved
Hide resolved
bulk-model-sync-mps/src/main/kotlin/org/modelix/mps/model/sync/bulk/MPSBulkSynchronizer.kt
Outdated
Show resolved
Hide resolved
…ter import into MPS In projects, loading all libraries and plugins can significant time. This workaround enables to sync projects better that do not want to load all libraries and plugins. With this workaround, the `name` or `resolveInfo` property of a target is used as the `resoleInfo` property on a reference even if the concept of the target could not be fully loaded.
odzhychko
force-pushed
the
MODELIX-813-set-resolveInfo-in-updated-modules-for-targets-without-concept
branch
from
4760368 to
dc44995
Compare
languitar
approved these changes
Jun 19, 2024
odzhychko
deleted the
MODELIX-813-set-resolveInfo-in-updated-modules-for-targets-without-concept
branch
|
🎉 This PR is included in version 8.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In projects, loading all libraries and plugins can take significant time. This workaround enables to sync projects better that do not want to load all libraries and plugins. With this workaround, the
nameorresolveInfoproperty of a target is used as theresoleInfoproperty on a reference even if the concept of the target could not be fully loaded.To be verified by reviewers