feat(model-server)!: Use ENTRYPOINT instead of CMD in the provided Docker image #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently, we have no documentation about the arguments of the model server and the docker container. |
languitar
requested changes
Jan 3, 2024
There was a problem hiding this comment.
In your commit message, you can use the BREAKING CHANGE trailer to explain what is breaking and how users get around it. That text goes into the changelog.
See here for an example: https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-description-and-breaking-change-footer
…cker image This follows best practices for Docker images. > You can use the exec form of ENTRYPOINT to set fairly stable default commands and arguments and then use either form of CMD to set additional defaults that are more likely to be changed. See https://docs.docker.com/engine/reference/builder/#exec-form-entrypoint-example Using a ENTRYPOINT in model-server docker container makes passing arguments easier. For example, `docker run modelix/model-server ./run-model-server.sh -inmemory` would be simplified to `docker run modelix/model-server -inmemory` BREAKING CHANGE: The previous entry point was the default `ENTRYPOINT ["/bin/sh", "-c"]`. Now it is `ENTRYPOINT ["./run-model-server.sh"]`. If you used `docker run modelix/model-server ./run-model-server.sh <args>` to pass arguments, you now have to use `docker run modelix/model-server <args>`. If you used any other process, you now have to override the entry point with the `--entrypoint` option. See https://docs.docker.com/engine/reference/run/#entrypoint-default-command-to-execute-at-runtime
languitar
approved these changes
Jan 8, 2024
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows best practices for Docker images.
Using a ENTRYPOINT in model-server docker container makes passing arguments easier.
For example,
docker run modelix/model-server ./run-model-server.sh -inmemorywould be simplified to
docker run modelix/model-server -inmemoryBREAKING CHANGE: The previous entry point was the default
ENTRYPOINT ["/bin/sh", "-c"].Now it is
ENTRYPOINT ["./run-model-server.sh"].If you used
docker run modelix/model-server ./run-model-server.sh <args>to pass arguments,you now have to use
docker run modelix/model-server <args>.If you used any other process, you now have to override the entry point with the
--entrypointoption.See https://docs.docker.com/engine/reference/run/#entrypoint-default-command-to-execute-at-runtime