Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(modelql): remove unneeded dependencies in modelql-server #1307

Merged
merged 1 commit into from
Jan 10, 2025
Merged

build(modelql): remove unneeded dependencies in modelql-server #1307

merged 1 commit into from
Jan 10, 2025

Conversation

odzhychko
Copy link
Contributor

Some decencies were unused. Others are already provided transitively by other dependencies.

To be verified by reviewers

  • Relevant public API members have been documented
  • Documentation related to this PR is complete
    • Boundary conditions are documented
    • Exceptions are documented
    • Nullability is documented if used
  • Touched existing code has been extended with documentation if missing
  • Code is readable
  • New features and fixed bugs are covered by tests

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Results

  196 files  ±0    196 suites  ±0   30m 27s ⏱️ +52s
1 087 tests ±0  1 079 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 097 runs  ±0  1 089 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit c93a7d6. ± Comparison against base commit 24e7224.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

JVM coverage report

Overall Project 54.82% ❌

There is no coverage information present for the Files changed

@odzhychko odzhychko marked this pull request as ready for review January 9, 2025 14:41
@odzhychko odzhychko requested review from slisson and a team as code owners January 9, 2025 14:41
@odzhychko odzhychko merged commit 3c94c06 into main Jan 10, 2025
21 checks passed
@odzhychko odzhychko deleted the cleanup-modelql-sever-dependencies branch January 10, 2025 10:51
@slisson
Copy link
Member

slisson commented Jan 14, 2025

🎉 This PR is included in version 11.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@languitar languitar languitar approved these changes

@slisson slisson Awaiting requested review from slisson slisson is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odzhychko @slisson @languitar