-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODELIX-829 Split INode interface into multiple interfaces #1306
base: main
Are you sure you want to change the base?
MODELIX-829 Split INode interface into multiple interfaces #1306
Conversation
Test Results22 tests 21 ✅ 19s ⏱️ For more details on these failures, see this check. Results for commit 21cf379. ♻️ This comment has been updated with latest results. |
b74e985
to
4602537
Compare
@@ -36,13 +36,15 @@ | |||
invalidate(containmentPath) | |||
} | |||
|
|||
override fun needsDescentIntoSubtree(subtreeRoot: INode): Boolean { | |||
override fun needsDescentIntoSubtree(subtreeRoot: IReadableNode): Boolean { | |||
val subtreeRoot = subtreeRoot.asLegacyNode() |
Check warning
Code scanning / detekt
Name shadowed: subtreeRoot Warning
require(subtreeRoot is PNodeAdapter) | ||
val path = subtreeRoot.branch.transaction.tree.ancestorsAndSelf(subtreeRoot.nodeId).toList().asReversed() | ||
return rootNode.needsDescentIntoSubtree(path, 0) | ||
} | ||
|
||
override fun needsSynchronization(node: INode): Boolean { | ||
override fun needsSynchronization(node: IReadableNode): Boolean { | ||
val node = node.asLegacyNode() |
Check warning
Code scanning / detekt
Name shadowed: node Warning
bulk-model-sync-mps/src/main/kotlin/org/modelix/mps/model/sync/bulk/NodeAssociations.kt
Fixed
Show fixed
Hide fixed
mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSChildLink.kt
Fixed
Show fixed
Hide fixed
mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSChildLink.kt
Fixed
Show fixed
Hide fixed
mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSProperty.kt
Fixed
Show fixed
Hide fixed
mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSProperty.kt
Fixed
Show fixed
Hide fixed
mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSReferenceLink.kt
Fixed
Show fixed
Hide fixed
mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSReferenceLink.kt
Fixed
Show fixed
Hide fixed
mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSReferenceLink.kt
Fixed
Show fixed
Hide fixed
6847456
to
29da845
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
87c751d
to
56a7eea
Compare
f9401cf
to
b05a4b1
Compare
…r and ModelSynchronizer
The bulk sync so far could only synchronize existing models, but not create new ones.
Since they are generated there is nothing the user can do to fix these warnings.
b05a4b1
to
82f68e3
Compare
82f68e3
to
9e302a5
Compare
821005e
to
21cf379
Compare
No description provided.