fix(mps-model-adapters): fix MPSNode.replaceNode #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 196 files 196 suites 30m 2s ⏱️ Results for commit 954860b. ♻️ This comment has been updated with latest results. |
JVM coverage report
|
languitar
reviewed
Jan 7, 2025
mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSNode.kt
Show resolved
Hide resolved
languitar
reviewed
Jan 7, 2025
mps-model-adapters-plugin/src/test/kotlin/org/modelix/model/mpsadapters/ReplaceNodeTest.kt
Outdated
Show resolved
Hide resolved
mps-model-adapters-plugin/src/test/kotlin/org/modelix/model/mpsadapters/ReplaceNodeTest.kt
Outdated
Show resolved
Hide resolved
slisson
requested changes
Jan 7, 2025
mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSNode.kt
Outdated
Show resolved
Hide resolved
mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSNode.kt
Outdated
Show resolved
Hide resolved
* correctly parse concept UID * check preconditions before making changes * remove child from parent before moving to new parent * correctly call `SNode.insertChildBefore`
slisson
reviewed
Jan 7, 2025
mps-model-adapters-plugin/src/test/kotlin/org/modelix/model/mpsadapters/ReplaceNodeTest.kt
Outdated
Show resolved
Hide resolved
…n `MPSNode.replaceNode`
slisson
approved these changes
Jan 8, 2025
|
🎉 This PR is included in version 11.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNode.insertChildBeforeTo be verified by reviewers