fix(modelql)!: disable implicit queries to avoid accidental performan…

…ce issues You should fix the unintended implicit queries or use .query explicitly. You can also set the environment variable MODELQL_IMPLICIT_QUERIES_ENABLED=true to re-enable this feature.
modelix · Dec 8, 2024 · 6ba247c · 6ba247c
1 parent b7734da
commit 6ba247c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/...adle-test/kotlin-generation/src/test/kotlin/org/modelix/modelql/typed/TypedModelQLTest.kt b/...adle-test/kotlin-generation/src/test/kotlin/org/modelix/modelql/typed/TypedModelQLTest.kt
@@ -227,7 +227,7 @@ class TypedModelQLTest {
                 .untyped()
                 .toList()
         }.map { it.typed<StaticMethodDeclaration>() }
-        assertEquals("plus", result[0].name)
+        assertEquals("plus", result[0].query { it.name })
     }
 
     @Test
@@ -239,7 +239,7 @@ class TypedModelQLTest {
                 .filter { it.visibility.instanceOf(C_PublicVisibility) }
                 .toList()
         }
-        assertEquals("plus", result[0].name)
+        assertEquals("plus", result[0].query { it.name })
     }
 
     @Test
@@ -257,8 +257,9 @@ class TypedModelQLTest {
                 .member
                 .ofConcept(C_StaticMethodDeclaration)
                 .first()
+                .name
         }
-        assertEquals(expected, actual.name)
+        assertEquals(expected, actual)
     }
 
     @Test
@@ -297,7 +298,7 @@ class TypedModelQLTest {
                 .first()
         }
         assertNotEquals(expected, oldValue)
-        assertEquals(expected, actual.variableDeclaration.name)
+        assertEquals(expected, actual.query { it.variableDeclaration.name })
     }
 
     @Test

diff --git a/modelql-client/src/jsMain/kotlin/org/modelix/modelql/client/ModelQLNode.js.kt b/modelql-client/src/jsMain/kotlin/org/modelix/modelql/client/ModelQLNode.js.kt
@@ -17,4 +17,4 @@
 package org.modelix.modelql.client
 
 actual val implicitQueriesEnabled: Boolean
-    get() = false
+    get() = false