Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add start and start:sse scripts to package.json on everything server #397

Conversation

apappascs
Copy link
Contributor

@apappascs apappascs commented Dec 22, 2024

Description

This PR adds start and start:sse scripts to the package.json file of the "everything" server. These scripts simplify the process of running the server in both standard and SSE mode.

Server Details

  • Server: everything
  • Changes to: package.json

Motivation and Context

Currently, to start the "everything" server, developers need to manually type out the command node dist/index.js for the standard mode and node dist/sse.js for the SSE mode. This can be cumbersome, especially during development and testing. Adding these scripts to package.json provides convenient shortcuts, making it easier to start the server with a simple npm start or npm run start:sse command.

How Has This Been Tested?

The changes were tested by running the following commands in the src/everything directory:

  1. npm start: This successfully started the server in standard mode.
  2. npm run start:sse: This successfully started the server in SSE mode.

No LLM client interaction was necessary for testing these script additions.

Breaking Changes

No, this change does not introduce any breaking changes. It only adds new scripts to package.json without altering the server's functionality or requiring any client-side modifications.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly (Not applicable, as this change is specific to the development workflow.)
  • I have tested this with an LLM client (Not applicable for this type of change.)
  • My code follows the repository's style guidelines
  • New and existing tests pass locally (Not applicable, as no tests are affected by this change.)
  • I have added appropriate error handling (Not applicable, as this change does not involve error handling.)
  • I have documented all environment variables and configuration options (Not applicable, as no new environment variables or configuration options were added.)

Additional context

The following lines were added to the scripts section of src/everything/package.json:

"start": "node dist/index.js",
"start:sse": "node dist/sse.js"

This change improves the developer experience by making it more convenient to run the "everything" server in different modes.

@dsp-ant dsp-ant force-pushed the main branch 28 times, most recently from 8622936 to ed3df93 Compare January 13, 2025 20:59
@dsp-ant dsp-ant force-pushed the main branch 26 times, most recently from c114833 to 4f3dc11 Compare January 14, 2025 03:05
Copy link
Contributor

@jerome3o-anthropic jerome3o-anthropic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thank you!

@jerome3o-anthropic jerome3o-anthropic merged commit daf9ef4 into modelcontextprotocol:main Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants