Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal.FunctionCall.gather to replace modal.functions.gather #2896

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Feb 24, 2025

Describe your changes

Moving gather to be a staticmethod on modal.FunctionCall makes it more discoverable and clarifies its purpose. Because we now import modal.FunctionCall into the top-level namespace, we no longer need to recommend using names directly from modal.functions, which helps enforce a clearer separation between public / private API.

  • Closes CLI-334
Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

  • We've moved the modal.functions.gather function to be a staticmethod on modal.FunctionCall.gather. The former spelling has been deprecated and will be removed in a future version.

@mwaskom mwaskom requested a review from freider February 24, 2025 23:10
Copy link
Contributor

@freider freider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@mwaskom mwaskom merged commit f83977d into main Feb 25, 2025
24 checks passed
@mwaskom mwaskom deleted the michael/2025-02-24-move-gather-to-function-call branch February 25, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants