Add modal.FunctionCall.gather
to replace modal.functions.gather
#2896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Moving
gather
to be a staticmethod onmodal.FunctionCall
makes it more discoverable and clarifies its purpose. Because we now importmodal.FunctionCall
into the top-level namespace, we no longer need to recommend using names directly frommodal.functions
, which helps enforce a clearer separation between public / private API.Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog
modal.functions.gather
function to be a staticmethod onmodal.FunctionCall.gather
. The former spelling has been deprecated and will be removed in a future version.