Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_image_cache config #2891

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Feb 21, 2025

Describe your changes

Adds a new field to the config, ignore_image_cache. This will be included in the ImageGetOrCreateRequest. It will effectively ignore the Image cache (in practice, it will include the App ID and version in the cache key). This can be useful for testing whether Apps can run when rebuilding an Image from top-to-bottom without then forcing other Apps that depend on the same base layer(s) to rebuild.

Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

  • Added a new config field, ignore_image_cache, which will cause Images used by the App to rebuild without clobbering any existing cached Images. This can be useful for testing an App's robustness to Image rebuilds without affecting other Apps that depend on the same base Image layer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant