Remove check for snapshot enabled locally #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
|
@prbot automerge |
|
Some required workflows are pending. Will automerge once they complete successfully. |
cweld510
force-pushed
the
cweld/remove-local-enable-snapshot-check
branch
from
d13ba5d to
686d3d1
Compare
|
Cannot automerge PR because it has new commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a local check in
Sandbox._experimental_snapshotthat verifies snapshots are enabled for the sandbox before snapshotting. We don't correctly hydrate the field we're checking correctly, and we also verify on the server.This fixes the issue quickly, for now. I've created a ticket to add back the local check (and add a test) once I figure out hydration.
Changelog
Sandbox.list()were not snapshottable even if they were created with_experimental_enable_snapshot.