Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fc_trace_tag field to FunctionOutput #2875

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

thecodingwizard
Copy link
Contributor

@thecodingwizard thecodingwizard commented Feb 14, 2025

This PR adds a fc_trace_tag field to FunctionGetOutputsItem, needed to provide end-to-end function call traces with Datdog.

We sample a very small number of function calls, and this field is only set for function calls we do sample, so this shouldn't actually impact many outputs.

This tag might also be useful for synmons, etc.

Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


@thecodingwizard thecodingwizard marked this pull request as ready for review February 14, 2025 20:10
@thecodingwizard thecodingwizard merged commit 1b8920b into main Feb 14, 2025
24 checks passed
@thecodingwizard thecodingwizard deleted the nathan/dd-trace branch February 14, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants