Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoscaler_settings to FunctionData as well #2874

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Feb 14, 2025

Forgot to do this in #2861 (still don't have my head quite wrapped around Function/FunctionData).

Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


@mwaskom mwaskom requested a review from irfansharif February 14, 2025 15:59
@mwaskom mwaskom force-pushed the michael/2025-02-14-function-data-autoscaler-settings branch from bc9939a to 4370512 Compare February 14, 2025 16:10
@mwaskom
Copy link
Contributor Author

mwaskom commented Feb 14, 2025

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @irfansharif will follow-up review this.

@mwaskom mwaskom merged commit 47f55f5 into main Feb 14, 2025
24 checks passed
@mwaskom mwaskom deleted the michael/2025-02-14-function-data-autoscaler-settings branch February 14, 2025 16:27
@irfansharif
Copy link
Member

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants