Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes double underscored deprecated field #2873

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

freider
Copy link
Contributor

@freider freider commented Feb 14, 2025

Should be unused now (no references in code base).
This breaks type checking on mypy-proto 3.4+ otherwise

This breaks type checking on mypy-proto 3.4+ otherwise
Copy link
Contributor

@mwaskom mwaskom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freider freider merged commit 66a4254 into main Feb 17, 2025
24 checks passed
@freider freider deleted the freider/remove-underscored-deprecated-field branch February 17, 2025 13:01
howard36 added a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants