Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include modal_docs subpackages in client installation/build #2872

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

devennavani
Copy link
Contributor

@devennavani devennavani commented Feb 14, 2025

Include modal_docs subpackages in client installation/build. #2871 was unfortunately not sufficient

@devennavani devennavani requested a review from mwaskom February 14, 2025 05:02
@devennavani
Copy link
Contributor Author

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

@devennavani devennavani merged commit 39a82b7 into main Feb 14, 2025
24 checks passed
@devennavani devennavani deleted the deven/include_modal_docs_subpackages branch February 14, 2025 05:20
Copy link
Contributor

@mwaskom mwaskom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we should probably still remove this once we have a better way of incorporating the client into the monorepo build but no harm in putting it back for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants