Migrate from legacy setup.py+setup.cfg to pyproject.toml-based packaging
#2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devennavani
changed the title
setup.py+setup.cfg to pyproject.toml
devennavani
changed the title
setup.py+setup.cfg to pyproject.tomlsetup.py+setup.cfg to pyproject.toml-based packaging
freider
reviewed
Feb 13, 2025
mwaskom
reviewed
Feb 13, 2025
| modal_proto = ["*.proto", "py.typed", "*.pyi"] | ||
|
|
||
| [tool.setuptools.dynamic] | ||
| version = {attr = "modal_version.__version__"} |
There was a problem hiding this comment.
Do we still need modal_version here? Seems like we could be dynamically getting the version from modal.__version__ (with that getting populated by some auto-generated file that lives under modal/).
There was a problem hiding this comment.
Yeah we can probably eliminate the need for the separate package -- that change has a couple of touch points so I'll make it in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our build system to use modern Python packaging standards by:
setup.cfgandsetup.pytopyproject.toml-based configurationsetuptoolsdirect usage to the standardized build package for creating distributionsChanges
setup.cfgtopyproject.tomlusing the[project]table formatsetup.pyin favor of dynamic version detection viapyproject.toml(seetool.setuptools.dynamic)pip install buildstep in CI workflow to install Python's standardized build frontend: https://github.com/pypa/buildpython -m buildinstead ofpython setup.py sdist bdist_wheelAll package specifications (dependencies, entry points, package data, etc.) remain functionally equivalent to the previous configuration.