Adds include_source on run_function #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
|
@prbot automerge |
|
Some required workflows are pending. Will automerge once they complete successfully. Please bear with us in this difficult time. |
modal-pr-review-automation
bot
deleted the
freider/include-source-on-run-function
branch
mwaskom
reviewed
Feb 12, 2025
| @@ -1924,6 +1924,8 @@ def run_function( | |||
| region: Optional[Union[str, Sequence[str]]] = None, # Region or regions to run the function on. | |||
| args: Sequence[Any] = (), # Positional arguments to the function. | |||
| kwargs: dict[str, Any] = {}, # Keyword arguments to the function. | |||
| *, | |||
There was a problem hiding this comment.
Would be nicer to have this right after raw_f but we'll need to do it gradually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted as a separate patch from #2860 so we can fix the integration tests before merging the patch that will break them
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.