-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add bytes strict type to parametrized functions #2837
base: main
Are you sure you want to change the base?
Conversation
…rom/add-bytes-param-functions-type
Need to merge the protos before merging this & merge the server-side code before this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found a bug, and a matching bug in the test that makes it pass :D
test/supports/functions.py
Outdated
|
||
@web_endpoint() | ||
def web(self, arg): | ||
return {"arg": arg, "bar": b"world"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should return self.bar right? :D
Describe your changes
Do not merge -- need to merge backend support before this.
Adds support for new strict
bytes
type formodal.parameter
Usage:
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog
Adds support for new strict
bytes
type formodal.parameter
Usage:
For parameterized functions with web hooks you must base64 encode the bytes before passing them in as a parameter.