Code

Client now retries .map() failures#2734

Code

Open

rculbertson wants to merge 19 commits intomainmodal-labs/modal-client:mainfrom ryan/retry-mapmodal-labs/modal-client:ryan/retry-mapCopy head branch name to clipboard

+1,322-94

Commits

Commits on Feb 19, 2025

• Add client retry support to .map

  

  rohansingh

  authored and

  rculbertson

  committed
  b95a03e

  Copy full SHA for b95a03e

• Track in-flight inputs by idx instead of input_id

  

  rohansingh

  authored and

  rculbertson

  committed
  b8872b1

  Copy full SHA for b8872b1

• Fix TimedPriorityQueue to work with duplicate timestamps

  Show description for 6d8dd4e
  

  rohansingh

  authored and

  rculbertson

  committed
  6d8dd4e

  Copy full SHA for 6d8dd4e

• Add unit tests for map retries

  

  rohansingh

  authored and

  rculbertson

  committed
  d390054

  Copy full SHA for d390054

• Respect MODAL_CLIENT_RETRIES setting for map

  

  rohansingh

  authored and

  rculbertson

  committed
  1a94903

  Copy full SHA for 1a94903

• Fix race condition between inputs/outputs

  Show description for 94d19de
  

  rohansingh

  authored and

  rculbertson

  committed
  94d19de

  Copy full SHA for 94d19de

• Fix deadlocks on large numbers of inputs

  Show description for fa7732b
  

  rohansingh

  authored and

  rculbertson

  committed
  fa7732b

  Copy full SHA for fa7732b

• Simplify implementation

  Show description for 2acce6b
  

  rohansingh

  authored and

  rculbertson

  committed
  2acce6b

  Copy full SHA for 2acce6b

• wip map retries

  rculbertson

  committed
  b2c088f

  Copy full SHA for b2c088f

• More fixes

  rculbertson

  committed
  ffa121d

  Copy full SHA for ffa121d

• Make compatible with 3.9

  rculbertson

  committed
  95d16ea

  Copy full SHA for 95d16ea

• Add tests and remove busy wait from queue

  rculbertson

  committed
  c8c281d

  Copy full SHA for c8c281d

• Remove debug logging

  rculbertson

  committed
  914c5ac

  Copy full SHA for 914c5ac

• Guard against duplicate outputs

  rculbertson

  committed
  e2c7177

  Copy full SHA for e2c7177

• Add attempt number

  rculbertson

  committed
  5ed1303

  Copy full SHA for 5ed1303

• Rename field to retry_count

  rculbertson

  committed
  b361b37

  Copy full SHA for b361b37

• Remove debug code

  rculbertson

  committed
  278c981

  Copy full SHA for 278c981

• Switch to using MapItemManager

  rculbertson

  committed
  b2190b6

  Copy full SHA for b2190b6

• Update structure of context and manager

  rculbertson

  committed
  cb4ff1b

  Copy full SHA for cb4ff1b