Skip to content

Commit

Permalink
Quick fix for accidentally *fixing* @build deps
Browse files Browse the repository at this point in the history
In version v0.73.55 we accidentally fixed one half of a bug
that previously would not add dependency objects to @build
methods of classes.

Fixing the other half of the bug would potentially cause behavior
changes in image.imports, so this fix simply re-breaks deps generation
inside of containers to not cause errors
  • Loading branch information
freider committed Feb 21, 2025
1 parent afac62c commit a3b9590
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion modal/_runtime/user_code_imports.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,9 @@ def import_single_function_service(
# The cls decorator is in global scope
_cls = synchronizer._translate_in(cls)
user_defined_callable = _cls._callables[fun_name]
service_deps = _cls._get_class_service_function().deps(only_explicit_mounts=True)
# Intentionally not including these, since @build functions don't actually
# forward the information from their parent class.
# service_deps = _cls._get_class_service_function().deps(only_explicit_mounts=True)
active_app = _cls._app
else:
# This is non-decorated class
Expand Down

0 comments on commit a3b9590

Please sign in to comment.