Update parameterization in vscode app

modal-labs · Feb 20, 2025 · 812b920 · 812b920
1 parent ceb19a1
commit 812b920
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/modal/_functions.py b/modal/_functions.py
@@ -1087,7 +1087,15 @@ async def keep_warm(self, warm_pool_size: int) -> None:
             """
                 )
             )
-        # TODO deprecation warn
+
+        deprecation_warning(
+            (2025, 2, 24),
+            "The .keep_warm() method has been deprecated in favor of the more general "
+            ".update_autoscaler(min_containers=...) method.",
+            pending=True,
+            show_source=True,
+        )
+
         await self.update_autoscaler(min_containers=warm_pool_size)
 
     @classmethod

diff --git a/modal/cli/programs/vscode.py b/modal/cli/programs/vscode.py
@@ -82,7 +82,7 @@ def wait_for_port(data: tuple[str, str], q: Queue):
     timeout=args.get("timeout"),
     secrets=[Secret.from_dict({"MODAL_LAUNCH_ARGS": json.dumps(args)})],
     volumes=volumes,
-    concurrency_limit=1 if volume else None,
+    max_containers=1 if volume else None,
 )
 def run_vscode(q: Queue):
     os.chdir("/home/coder")