Skip to content

Commit

Permalink
signal: errors should not start with a capital
Browse files Browse the repository at this point in the history
Signed-off-by: Sebastiaan van Stijn <[email protected]>
  • Loading branch information
thaJeztah committed Aug 7, 2021
1 parent 511c2cb commit 1a1d2af
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions signal/signal.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ func ParseSignal(rawSignal string) (syscall.Signal, error) {
s, err := strconv.Atoi(rawSignal)
if err == nil {
if s == 0 {
return -1, fmt.Errorf("Invalid signal: %s", rawSignal)
return -1, fmt.Errorf("invalid signal: %s", rawSignal)
}
return syscall.Signal(s), nil
}
signal, ok := SignalMap[strings.TrimPrefix(strings.ToUpper(rawSignal), "SIG")]
if !ok {
return -1, fmt.Errorf("Invalid signal: %s", rawSignal)
return -1, fmt.Errorf("invalid signal: %s", rawSignal)
}
return signal, nil
}
Expand Down
4 changes: 2 additions & 2 deletions signal/signal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ import (

func TestParseSignal(t *testing.T) {
_, err := ParseSignal("0")
expectedErr := "Invalid signal: 0"
expectedErr := "invalid signal: 0"
if err == nil || err.Error() != expectedErr {
t.Errorf("expected %q, but got %v", expectedErr, err)
}

_, err = ParseSignal("SIG")
expectedErr = "Invalid signal: SIG"
expectedErr = "invalid signal: SIG"
if err == nil || err.Error() != expectedErr {
t.Errorf("expected %q, but got %v", expectedErr, err)
}
Expand Down

0 comments on commit 1a1d2af

Please sign in to comment.