Skip to content

Commit

Permalink
fix: 🐛 convert app logo from svg to png
Browse files Browse the repository at this point in the history
convert app logo from svg to png because a bug prevents it from display in release
  • Loading branch information
moazelsawaf committed Mar 27, 2023
1 parent 7ac43da commit 21b9f62
Show file tree
Hide file tree
Showing 8 changed files with 6 additions and 110 deletions.
Binary file added assets/images/app_logo/app_logo_colored.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/app_logo/app_logo_white.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 0 additions & 22 deletions assets/svgs/app_logo/app_logo_colored.svg

This file was deleted.

24 changes: 0 additions & 24 deletions assets/svgs/app_logo/app_logo_white.svg

This file was deleted.

3 changes: 1 addition & 2 deletions lib/ui/widgets/app_logo.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import 'package:flutter/material.dart';
import 'package:flutter_svg/flutter_svg.dart';
import 'package:made_with_flutter/utils/assets_manager.dart';

enum AppLogoType { colored, white }
Expand All @@ -16,7 +15,7 @@ class AppLogo extends StatelessWidget {

@override
Widget build(BuildContext context) {
return SvgPicture.asset(
return Image.asset(
_logo,
width: size,
height: size,
Expand Down
7 changes: 3 additions & 4 deletions lib/utils/assets_manager.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,17 @@ class AssetsManager {
// Main Folders
static const _assetsFolder = 'assets';
static const _imagesFolder = '$_assetsFolder/images';
static const _svgsFolder = 'svgs';
static const _lottieFolder = '$_assetsFolder/lottie';

// Sub Folders
static const _appLogoFolder = '$_svgsFolder/app_logo';
static const _appLogoFolder = '$_imagesFolder/app_logo';

// Images
static const desktopBackground = '$_imagesFolder/desktop_background.jpg';

// SVGs
static const appLogoColored = '$_appLogoFolder/app_logo_colored.svg';
static const appLogoWhite = '$_appLogoFolder/app_logo_white.svg';
static const appLogoColored = '$_appLogoFolder/app_logo_colored.png';
static const appLogoWhite = '$_appLogoFolder/app_logo_white.png';

// Lottie
static const filesProcessing = '$_lottieFolder/files_processing.json';
Expand Down
58 changes: 1 addition & 57 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,6 @@ packages:
url: "https://pub.dev"
source: hosted
version: "3.3.6"
args:
dependency: transitive
description:
name: args
sha256: "4cab82a83ffef80b262ddedf47a0a8e56ee6fbf7fe21e6e768b02792034dd440"
url: "https://pub.dev"
source: hosted
version: "2.4.0"
async:
dependency: transitive
description:
Expand Down Expand Up @@ -166,14 +158,6 @@ packages:
url: "https://pub.dev"
source: hosted
version: "2.0.1"
flutter_svg:
dependency: "direct main"
description:
name: flutter_svg
sha256: "12006889e2987c549c4c1ec1a5ba4ec4b24d34d2469ee5f9476c926dcecff266"
url: "https://pub.dev"
source: hosted
version: "2.0.4"
flutter_test:
dependency: "direct dev"
description: flutter
Expand Down Expand Up @@ -264,14 +248,6 @@ packages:
url: "https://pub.dev"
source: hosted
version: "1.0.1"
petitparser:
dependency: transitive
description:
name: petitparser
sha256: "49392a45ced973e8d94a85fdb21293fbb40ba805fc49f2965101ae748a3683b4"
url: "https://pub.dev"
source: hosted
version: "5.1.0"
plugin_platform_interface:
dependency: transitive
description:
Expand Down Expand Up @@ -429,30 +405,6 @@ packages:
url: "https://pub.dev"
source: hosted
version: "3.0.5"
vector_graphics:
dependency: transitive
description:
name: vector_graphics
sha256: "4cf8e60dbe4d3a693d37dff11255a172594c0793da542183cbfe7fe978ae4aaa"
url: "https://pub.dev"
source: hosted
version: "1.1.4"
vector_graphics_codec:
dependency: transitive
description:
name: vector_graphics_codec
sha256: "278ad5f816f58b1967396d1f78ced470e3e58c9fe4b27010102c0a595c764468"
url: "https://pub.dev"
source: hosted
version: "1.1.4"
vector_graphics_compiler:
dependency: transitive
description:
name: vector_graphics_compiler
sha256: "0bf61ad56e6fd6688a2865d3ceaea396bc6a0a90ea0d7ad5049b1b76c09d6163"
url: "https://pub.dev"
source: hosted
version: "1.1.4"
vector_math:
dependency: transitive
description:
Expand All @@ -461,14 +413,6 @@ packages:
url: "https://pub.dev"
source: hosted
version: "2.1.4"
xml:
dependency: transitive
description:
name: xml
sha256: "979ee37d622dec6365e2efa4d906c37470995871fe9ae080d967e192d88286b5"
url: "https://pub.dev"
source: hosted
version: "6.2.2"
sdks:
dart: ">=2.19.3 <3.0.0"
flutter: ">=3.7.0-0"
flutter: ">=3.3.0"
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ dependencies:
flutter_dropzone: ^3.0.5
archive: ^3.3.6
elegant_notification: ^1.8.1
flutter_svg: ^2.0.4

dev_dependencies:
flutter_test:
Expand All @@ -35,4 +34,5 @@ flutter:

assets:
- assets/images/
- assets/images/app_logo/
- assets/lottie/

0 comments on commit 21b9f62

Please sign in to comment.