Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improved typing, event based signatures, issue #15 #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mnesarco
Copy link
Owner

This PR is massive, but it is primarily because of added typing and resolved linting issues.

The important change is the change of event handlers signatures to be based on Event types instead of discrete arguments.

Global changes

  • Added ruff linter and formatter

fpo

  • Explicit Property constructors to help linters and autocompletion
  • [breaking] Changed callback methods signature to accept single event object or nothing
  • Added events namespace with all *Event types
  • Added DataProxy and ViewProxy protocols for documentation
  • Updated Property* constructors, generated from FreeCAD source Application.cpp
  • Improved typings

fcui

  • Improved typings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant