Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _close() on MNEAnnotationsFigure and MNESelectionFigure #13086

Merged
merged 3 commits into from
Jan 27, 2025

Merge branch 'main' into close

18149f2
Select commit
Loading
Failed to load commit list.
Merged

Fix _close() on MNEAnnotationsFigure and MNESelectionFigure #13086

Merge branch 'main' into close
18149f2
Select commit
Loading
Failed to load commit list.
Azure Pipelines / mne-tools.mne-python succeeded Jan 27, 2025 in 25m 55s

Build #20250127.1 had test failures

0 errors / 0 warnings

Details

Tests

  • Failed: 1 (0.01%)
  • Passed: 9,827 (98.25%)
  • Other: 174 (1.74%)
  • Total: 10,002
Code coverage

  • 135763 of 243000 lines covered (55.87%)

Annotations

Check failure on line 1 in test_plot_raw_traces[qt]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / mne-tools.mne-python

test_plot_raw_traces[qt] 

RuntimeWarning: Error calling Python override of QGraphicsView::mouseReleaseEvent(): Error calling Python override of QGraphicsScene::mouseReleaseEvent(): Error sending click event:
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.12.8/x64/bin/pytest", line 8, in <module>
    sys.exit(console_main())
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/config/__init__.py", line 201, in console_main
    code = main()
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/config/__init__.py", line 175, in main
    ret: ExitCode | int = config.hook.pytest_cmdline_main(config=config)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_hooks.py", line 513, in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_manager.py", line 120, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_callers.py", line 103, in _multicall
    res = hook_impl.function(*args)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/main.py", line 330, in pytest_cmdline_main
    return wrap_session(config, _main)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/main.py", line 283, in wrap_session
    session.exitstatus = doit(config, session) or 0
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/main.py", line 337, in _main
    config.hook.pytest_runtestloop(session=session)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_hooks.py", line 513, in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_manager.py", line 120, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_callers.py", line 103, in _multicall
    res = hook_impl.function(*args)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/main.py", line 362, in pytest_runtestloop
    item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_hooks.py", line 513, in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_manager.py", line 120, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_callers.py", line 103, in _multicall
    res = hook_impl.function(*args)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/runner.py", line 113, in pytest_runtest_protocol
    runtestprotocol(item, nextitem=nextitem)
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/runner.py", line 132, in runtestprotocol
    reports.append(call_and_report(item, "call", log))
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/runner.py", line 241, in call_and_report
    call = CallInfo.from_call(
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/runner.py", line 341, in from_call
    result: TResult | None = func()
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/runner.py", line 242, in <lambda>
    lambda: runtest_hook(item=item, **kwds), when=when, reraise=reraise
  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_hooks.py", line 513, in __call__
Raw output 
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pyqtgraph/GraphicsScene/GraphicsScene.py:378: in sendClickEvent
    item.mouseClickEvent(ev)
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/mne_qt_browser/_pg_figure.py:778: in mouseClickEvent
    trace.toggle_bad()
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/mne_qt_browser/_pg_figure.py:576: in toggle_bad
    self.weakmain()._apply_update_projectors()
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/mne_qt_browser/_pg_figure.py:5110: in _apply_update_projectors
    self._redraw()
mne/viz/_figure.py:420: in _redraw
    self._update_data()
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/mne_qt_browser/_pg_figure.py:4853: in _update_data
    self.mne.times = self.mne.global_times[start:stop]
E   AttributeError: 'BrowserParams' object has no attribute 'global_times'

During handling of the above exception, another exception occurred:
mne/viz/tests/test_raw.py:571: in test_plot_raw_traces
    fig._click_ch_name(ch_index=0, button=1)
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/mne_qt_browser/_pg_figure.py:5515: in _click_ch_name
    self._fake_click((x, y), fig=self.mne.view, button=button, xform="none")
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/mne_qt_browser/_pg_figure.py:5476: in _fake_click
    _mouseClick(widget=widget, pos=point, button=button, modifier=modifier)
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/mne_qt_browser/_pg_figure.py:5681: in _mouseClick
    _mouseRelease(widget, pos, button, modifier)
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/mne_qt_browser/_pg_figure.py:5664: in _mouseRelease
    QApplication.sendEvent(widget, event)
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pyqtgraph/widgets/GraphicsView.py:343: in mouseReleaseEvent
    super().mouseReleaseEvent(ev)
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pyqtgraph/GraphicsScene/GraphicsScene.py:223: in mouseReleaseEvent
    if self.sendClickEvent(cev[0]):
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pyqtgraph/GraphicsScene/GraphicsScene.py:380: in sendClickEvent
    debug.printExc("Error sending click event:")
/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pyqtgraph/debug.py:137: in printExc
    warnings.warn("\n".join([msg, exc]), RuntimeWarning, stacklevel=2)
E   RuntimeWarning: Error calling Python override of QGraphicsView::mouseReleaseEvent(): Error calling Python override of QGraphicsScene::mouseReleaseEvent(): Error sending click event:
E   Traceback (most recent call last):
E     File "/opt/hostedtoolcache/Python/3.12.8/x64/bin/pytest", line 8, in <module>
E       sys.exit(console_main())
E     File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/config/__init__.py", line 201, in console_main
E       code = main()
E     File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/config/__init__.py", line 175, in main
E       ret: ExitCode | int = config.hook.pytest_cmdline_main(config=config)
E     File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_hooks.py", line 513, in __call__
E       return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
E     File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_manager.py", line 120, in _hookexec
E       return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
E     File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/pluggy/_callers.py", line 103, in _multicall
E       res = hook_impl.function(*args)
E     File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/_pytest/main.py", line 330, in pytest_cmdline_main
E       return wrap_session(config, _main)
E     File "/opt/hostedtoolcache/Python/3.12.
View more details on Azure Pipelines