Backport PR #13067 on branch maint/1.9 ([BUG] Fix taper weighting in computation of TFR multitaper power) #13072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hting in computation of TFR multitaper power) Co-Authored-By: Eric Larson <[email protected]>
tsbinns
requested review from
larsoner,
drammock,
agramfort,
dengemann,
adam2392 and
mscheltienne
as code owners
|
Thanks @tsbinns ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@larsoner My attempt at a manual backport of #13067 due to some merge conflicts.
Also had to add some code from #12910 which ensured the correct weights were returned from
_make_dpss, and removed part of a unit test that would no longer function (to do so would require API changes introduced in #12910).