Fix deprecation warnings with newer versions of dependencies. #13049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened matplotlib/matplotlib#29427 to fix the matplotlib bug. Will push a fix for sklearn next, along with a temporary don't-use-matplotlib-dev that we'll want for a day or two. |
larsoner
approved these changes
Jan 7, 2025
larsoner
requested review from
hoechenberger,
agramfort,
dengemann,
sappelhoff and
cbrnr
as code owners
agramfort
approved these changes
Jan 7, 2025
wmvanvliet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SciPy 1.15.0 uses
scipy.special.sph_harm_yoverscipy.special.sph_harmand throws deprecation warnings, causing our unit tests to fail. Since we want to keep supporting lower versions of SciPy, I've added a wrapper inmne/fixes.pyto smooth things over. The wrapper can be removed once we no longer support SciPy < 1.15.0Note that the order of the parameters has changed for
sph_harm_y, something which is not obvious if you just look at the names of the parameters in their docs.