-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read MIT Annotations #13030
base: main
Are you sure you want to change the base?
Read MIT Annotations #13030
Conversation
for more information, see https://pre-commit.ci
Co-authored-by: Eric Larson <[email protected]>
Where is the best place to list the suffix mappings @larsoner? The WFBD library mentions a few that I would also like to include besides |
for more information, see https://pre-commit.ci
Okay, everything should be good then. Should I add tests and include a citation for the library somewhere? @larsoner |
for more information, see https://pre-commit.ci
Sure, it would be good to add it to |
Reference issue (if any)
Fixes #12660.
What does this implement/fix?
Adds the ability to read WaveForm Database (wfdb) annotations using the already existing library. My proposed API adds two new parameters to
mne.read_annotations()
fmt
andsuffix
.fmt
andsuffix
are used in combination to read an annotation whose file suffix is not strictly defined.If
mne.annotations(fmt='wfbd'...)
is called with no suffix, then the function will check to see if the suffix matches a default list of suffixes.If
mne.annotations(fmt='wfbd', suffix='seizures'...)
is called, then the function will bypass the default list of suffixes.